firebase / firebase/firebase-admin-node

Filter.or over a missing field breaks the whole query silently

Open
#2,952 2 comments 0 reactions 1 assignee Claimed by @dconeybe View on GitHub
api: firestore
Dominant language
TypeScript
Stars
1.7k
Forks
419
Avg merge
3d 10h
Merged PRs (30d)
16

Description

### [REQUIRED] Step 2: Describe your environment

Live.
It works in the emulator.

### [REQUIRED] Step 3: Describe the problem

#### Steps to reproduce:

If one or more of the filters inside a `Filter.or` queries a non-existent property, then the whole `Filter.or` returns false, returning no results, even if the other filters (e.g. Age in the example below) do match.
No errors or warnings are raised, the query "fails" silently.

#### Relevant Code:

```
let snap = await firestore.collection('MyThing').where(
Filter.or(
Filter.where('age', '>=', 18),
Filter.where('nonExistentProperty', '>=', 123),
)
).get()
```

I get the limitations on querying non-existent fields, but the whole thing shouldn't fail silently.

Either the other filters should still work, or there should be an error raised.

This doesn't occurr on the emulator, so was only a prod issue that it just took me several hours to track down.

At least make the emulator mirror live!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.