firebase / firebase/firebase-admin-node

Discrepancy in Admin SDK's updateUser and client JS SDK's updateProfile functions

Abierto
#1,955 0 comentarios 0 reacciones 0 asignados Ver en GitHub
api: auth type: bug
Lenguaje dominante
TypeScript
Estrellas
1.7k
Forks
419
Merge medio
3 d 10 h
PR fusionados (30 d)
16

Descripción

### [REQUIRED] Step 2: Describe your environment

* Operating System version: MacOS 12.4
* Firebase SDK version: firebase-admin@10.3.0
* Firebase Product: Auth
* Node.js version: 16.17.1
* NPM version: 8.15.0

### [REQUIRED] Step 3: Describe the problem

#### Steps to reproduce:

There seem to be a discrepancy between how Admin SDK's `updateUser` works versus client JS SDK's `updateProfile` - more specifically how the `photoURL` field is being validated.

For example, using the client-side Firebase JS SDK we can update the `photoURL` to be a relative path which we later on assemble in order to render the actual profile photo.

This works just fine:

```
import firebase from 'firebase/app';

await firebase.auth().currentUser?.updateProfile({
photoURL: 'users/abc_123.jpg'
});
```

However, when updating the photo URL using Admin SDK (from the Firebase function), there seem to be additional validation step which requires the `photoURL` to be a valid URL starting with `http` or `https`.

So, this doesn't work because error `FirebaseAuthError: The photoURL field must be a valid URL.` is being thrown:

```
const admin = require('firebase-admin');

admin.auth().updateUser('...', {
photoURL: 'users/abc_123.jpg'
});
```

In my opinion there shouldn't be URL validation because Firebase Auth itself doesn't impose validation and plus it breaks our efforts to reuse the logic in both backend and frontend because if we try to update the profile photo from the backend, it breaks the way how we handle image rendering as we can't hard-code the whole URL since it changes based on some internal logic.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start by reproducing the discrepancy with Admin SDK auth().updateUser and the client JS SDK currentUser.updateProfile using the relative photoURL shown in the issue. Compare the two validation paths and their existing tests, if present; done means the supported behavior is aligned or the limitation is explicitly documented.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
javascript, node.js
Área
authentication, backend
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
38/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.