firebase / firebase/firebase-admin-node

imageUrl with special characters, are not allowed in firebase messaging. But there exists a lots of image urls with different special characters.

Ouverte
#1,213 4 commentaires 1 réaction 0 personnes assignées Voir sur GitHub
api: messaging
Langage dominant
TypeScript
Étoiles
1.7k
Forks
419
Merge moyen
3 j 10 h
PR mergées (30 j)
16

Description

Environment:
* Operating System Version: Ubuntu 20.04.2 LTS
* Firebase SDK version: 9.4.1
* Firebase Product: messaging (fcm)
* Node.js version: v12.21.0
* NPM Version: 6.14.11

Steps to reproduce:

* Following code is in typescript.

```
import * as admin from 'firebase-admin';

let message: admin.messaging.MulticastMessage = {
tokens: [""],
notification: {
title: "This is a test notification on fcm",
body: "This notification is to check if image with specials chars can be sent in fcm notification",
imageUrl: "https://s.yimg.com/uu/api/res/1.2/8e4p0MNjKRtV25O3t_qSMw--~B/aD00MjU7dz04MDA7YXBwaWQ9eXRhY2h5b24-/https://media.zenfs.com/en/nextshark_articles_509/287cce64e3a1cd49446e8751b89262ef"
}
}
admin.messaging().sendMulticast(message)
.then((response: admin.messaging.BatchResponse) => {
console.log("Message has been sent...");
})
.catch((error: any) => {
console.log(error);
// This notification throws here, and flow comes in this section
// Error is "notification.imageUrl must be a valid URL string"
});
```

As we see, the above example, the imageUrl has multiple special characters, still it is an URL which can surely load an image.
But, firebase admin doesn't accept this.

Hope to see some upgrades in the pattern checking rules of imageUrl.

Thanks.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.