firebase / firebase/firebase-admin-java

[FR] Improvement: Change updateChildren parameter to Map<String, ?>

Open
#917 2 comments 0 reactions 0 assignees View on GitHub
needs-triage type: feature request
Dominant language
Java
Stars
620
Forks
305
Avg merge
3h 23m
Merged PRs (30d)
1

Description

**Is your feature request related to a problem? Please describe.**
Various builders (e.g., `Map.of`) and language features (e.g., Groovy and Kotlin inline maps) create `Map` instances whose `V` bound is more strict than `Object`. Currently, the `DatabaseRef#updateChildren[Async]` interface won't accept these instances because it is defined as accepting `Map`.

**Describe the solution you'd like**
Since these method consume the map and do not modify it, they could be defined as `Map` to accept a map with any generic value type with no backwards incompatibility or other code changes.

**Describe alternatives you've considered**
Otherwise, passing in maps usually requires an explicit type declaration instead of `var` or an inline builder.

Contributor guide

Open the contributing guide

Research direction

Search for the DatabaseRef#updateChildren and updateChildrenAsync entry points, then inspect their declarations and any related tests. Confirm that the methods accept Map without changing their existing update behavior, and run the relevant Java test suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
databases
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.