firebase / firebase/firebase-admin-java

[FR] - Need a setter to set FCM host for Functional tests/Service Level tests.

Offen
#802 5 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen
needs-triage type: feature request
Vorherrschende Sprache
Java
Sterne
620
Forks
305
Ø Merge
3 Std. 23 Min.
Gemergte PRs (30 T.)
1

Beschreibung

**Summary**:
I recently integrated FCM SDK to send Push Notifications. The integration was very simple and smooth but while I started writing Functional Tests, I got to know that I can't give FCM host while constructing a `FcmMessaging` object. The `FCM_URL` is hardcoded in the `FirebaseMessagingClientImpl` class, which is restricting me from writing functional tests.

**Solution**:
While constructing the `FcmMessaging` object or while initializing `FirebaseApp` there can be an option to pass the FCM host. If the host is not passed then the default hardcoded host must be used.

**Describe alternatives you've considered**
Currently, due to this, I'm blocked from writing FTs. I'm currently only dependent on UTs

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start by reading FirebaseMessagingClientImpl to trace how FCM_URL is set and inspect the construction paths for FcmMessaging and FirebaseApp. Done means callers can provide an FCM host for functional or service-level tests while the default hardcoded host remains effective when no host is supplied.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
firebase, java
Bereich
backend-api-design, testing
Issue-Typ
Feature
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
42/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.