firebase / firebase/firebase-admin-java

Auth list tenants is not pageable

Offen
#1,192 3 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Java
Sterne
620
Forks
305
Ø Merge
3 Std. 23 Min.
Gemergte PRs (30 T.)
1

Beschreibung

* Firebase SDK version: 9.8.0
* Firebase Product: auth

Fetching tenants with firebaseAuth.getTenantManager().listTenants(null) does not return a PageToken even though more pages exist. There is no possibility to page through all tenants.

```java
private List getAllTenants() {
ListTenantsPage listTenantsPage = null;
List allTenants = new ArrayList<>();
try {
do {
listTenantsPage = firebaseAuth.getTenantManager().listTenants(listTenantsPage == null ? null : listTenantsPage.getNextPageToken());
for (Tenant tenant : listTenantsPage.iterateAll()) {
allTenants.add(tenant);
}
log.info("Next page token: {}", listTenantsPage.getNextPageToken());
} while (listTenantsPage.hasNextPage());
} catch (FirebaseAuthException e) {
log.error("Could not list tenants", e);
}
log.info("Found {} tenants", allTenants.size());
return allTenants;
}
```

When viewing the tenants in the GCP Identity Platform, the same request is used with a page size of 2147483647. However, the admin sdk prevents requesting a page size over 100 (FirebaseTenantClient.MAX_LIST_TENANTS_RESULTS).

Please either remove the page size restriction in the sdk or fix pagination with page token of tenants

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start with FirebaseTenantClient.MAX_LIST_TENANTS_RESULTS and the TenantManager.listTenants call shown in the report. Run or inspect the existing ListTenantsPage pagination behavior, comparing it with the GCP Identity Platform request described. Done means tenants can be retrieved across all available pages without the SDK incorrectly preventing the required request.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
java
Bereich
api, authentication
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
45/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.