firebase / firebase/firebase-admin-java

9.0.0 to 9.3.0 sendMulticastAsync vs sendEachForMulticastAsync. Server crashes when sending too many pushes

Aperta
#1,001 4 commenti 0 reazioni 1 assegnatario Rivendicata da @Doris-Ge Vedi su GitHub
api: messaging
Lingua principale
Java
Stelle
620
Fork
305
Merge medio
3h 23m
PR unite (30g)
1

Descrizione

### [REQUIRED] Step 2: Describe your environment

* Operating System version: debian / grails / groovy / java 11
* Firebase SDK version: 9.3.0
* Library version: _____
* Firebase Product: admin

### [REQUIRED] Step 3: Describe the problem
We switched out the firebase admin version from 9.0.0 to 9.3.0 yesterday. Sending out a few pushes works fine, but we sometimes send out a few millions in a "batch". There never were issues with the old sendMulticastAsync

ApiFuture apiFuture = FirebaseMessaging.getInstance().sendEachForMulticastAsync(multicastMessage)

apiFuture.addListener({
def batchResponse = apiFuture.get()
if (batchResponse != null && batchResponse.failureCount > 0) {
for (int i = 0; i < batchResponse.responses.size(); i++) {
def response = batchResponse.responses.get(i)
if (response != null && !response.successful && response.exception != null && (
(ErrorCode.NOT_FOUND == response.exception.errorCode && MessagingErrorCode.UNREGISTERED == response.exception.messagingErrorCode) ||
(ErrorCode.INVALID_ARGUMENT == response.exception.errorCode && MessagingErrorCode.INVALID_ARGUMENT == response.exception.messagingErrorCode))) {
UidRemovalJob.removalCandidates.add(new UidRemovalCandidate(phoneId: tokenList[i], os: 2))
}
}
}
}, executorServiceAndroidResponses)

Does this need to be switched to another implementation?

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.