felixge / felixge/node-sandboxed-module

Circular requires that work with regular requires do not work with sandboxed-module

未关闭
#50 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
343
派生
41
PR 合并指标
30 天内没有已合并 PR

描述

[Node.js supports circular requires](https://nodejs.org/api/modules.html#modules_cycles)
The behavior can be odd or unexpected, but it is supported.

In some cases though, this library is loading these circular requires differently, causing them to fail.

I posted an example of such a situation here: https://github.com/thoughtless/circular_require_demo

Another example is the [NPM module](https://www.npmjs.com/package/aws-sdk) `aws-sdk`. It has a circular require between [service.js](https://github.com/aws/aws-sdk-js/blob/08de9516754ea98b88bcc186c8b6ffbf89458502/lib/service.js#L1) and [core.js](https://github.com/aws/aws-sdk-js/blob/08de9516754ea98b88bcc186c8b6ffbf89458502/lib/core.js#L73).
`require("sandboxed-module").require("aws-sdk")` will fail.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。