fastruby / fastruby/fast-ruby

string/concatenation.rb tests are misleading

未关闭
#64 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Ruby
星标
5.7k
派生
371
PR 合并指标
30 天内没有已合并 PR

描述

Hi, the tests in `string/concatenation.rb` are quite misleading.

The fast method consists of this

```
def fast
'foo' 'bar'
end
```

That's not concatenating during calling of `fast` but on parsing the code. If you write another method just returning `foobar`, it is as fast as this method.

So I think this is not fair comparison and what you usually want is to concatenate two variables during runtime.

For this use case `concat` and `<<` are calling the same code, so they have the same performance and both are fine if you want to change the string on the left and not just get two strings concatenated. If you want a new string you can use `+`.

Some better test could be to compare `+` and String interpolation

```
Benchmark.ips do |x|
foo = 'foo'
bar = 'bar'

x.report('String#+') do
foo + bar
end

x.report('String interpolation') do
"#{foo}#{bar}"
end

x.compare!
end
```

This still has the difference that interpolation can handle nil values, while `+` cannot.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。