fastruby / fastruby/fast-ruby

e2mmap benchmark is not working (missing gem) in Ruby 3.0.x

Abierto
#196 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Ruby
Estrellas
5.7k
Forks
371
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Hi there,

At the moment this benchmark is not working:

```
➜ fast-ruby git:(master) ✗ ruby -v code/general/raise-vs-e2mmap.rb
ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-darwin20]
:85:in `require': cannot load such file -- e2mmap (LoadError)
from :85:in `require'
from code/general/raise-vs-e2mmap.rb:2:in `'
```

The solution would be to add this to the Gemfile:

```
gem 'e2mmap'
```

It seems that that benchmark might not be wanted in this project. After all, it is comparing Ruby vs. using the e2mmap gem. See: https://github.com/JuanitoFatas/fast-ruby/issues/95

I'm going to submit a PR removing that scenario, which should fix this issue. 😄

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.