fastify / fastify/pre-commit

Inaccurate path to @fastify/pre-commit/hook

Abierto
#32 5 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
14
Forks
6
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

### Prerequisites

- [X] I have written a descriptive issue title
- [X] I have searched existing issues to ensure it has not already been reported

### Fastify version

0.0.0

### Plugin version

2.0.2

### Node.js version

10.19.0

### Operating system

Linux

### Operating system version (i.e. 20.04, 11.3, 10)

ubuntu 20.04

### Description

This fixes the installation to correctly find the .git folder to install...when running "npm install" in a subfolder:
https://github.com/fastify/pre-commit/issues/17

```
.git/
web/
web/node_modules
web/package.json
...
```

but if you look at the pre-commit it executing:
./node_modules/@fastify/pre-commit/hook

that should be
./web/node_modules/@fastify/pre-commit/hook

### Steps to Reproduce

1. create a folder "web" same level as .git
2. cd web
3. npm install --save-dev @fastify/pre-commit
4. test a commit - errors
5. cat .git/hooks/pre-commit
6. see './node_modules/@fastify/pre-commit/hook' instead of './web/node_modules/@fastify/pre-commit/hook"

### Expected Behavior

expect to see './web/node_modules/@fastify/pre-commit/hook' instead of './node_modules/@fastify/pre-commit/hook"

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.