fastify / fastify/pre-commit

Inaccurate path to @fastify/pre-commit/hook

Open
#32 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
14
Forks
6
PR merge metrics
No merged PRs in 30d

Description

### Prerequisites

- [X] I have written a descriptive issue title
- [X] I have searched existing issues to ensure it has not already been reported

### Fastify version

0.0.0

### Plugin version

2.0.2

### Node.js version

10.19.0

### Operating system

Linux

### Operating system version (i.e. 20.04, 11.3, 10)

ubuntu 20.04

### Description

This fixes the installation to correctly find the .git folder to install...when running "npm install" in a subfolder:
https://github.com/fastify/pre-commit/issues/17

```
.git/
web/
web/node_modules
web/package.json
...
```

but if you look at the pre-commit it executing:
./node_modules/@fastify/pre-commit/hook

that should be
./web/node_modules/@fastify/pre-commit/hook

### Steps to Reproduce

1. create a folder "web" same level as .git
2. cd web
3. npm install --save-dev @fastify/pre-commit
4. test a commit - errors
5. cat .git/hooks/pre-commit
6. see './node_modules/@fastify/pre-commit/hook' instead of './web/node_modules/@fastify/pre-commit/hook"

### Expected Behavior

expect to see './web/node_modules/@fastify/pre-commit/hook' instead of './node_modules/@fastify/pre-commit/hook"

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.