facultyai / facultyai/faculty

list_jobs limit argument needs clarification or more suitable default value

Abierto
#169 1 comentario 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Python
Estrellas
16
Forks
5
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

In `JobClient`, the `list_jobs` function has a `limit` argument, which sets the number of jobs returned in a single request. The default value is is `None` in the library, which means "use the default limit from the backend service". That default value is (I believe) `10`.

https://github.com/facultyai/faculty/blob/master/faculty/clients/job.py#L314

Had a request to use that upstream default value in the library to make the effect of different values clearer. Otherwise interpreting the behaviour of `None` is difficult (for example will there be paging in that case or all records are returned?)

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.