facultyai / facultyai/faculty

Token caching with custom profiles

Aperta
#105 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Python
Stelle
16
Fork
5
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Token caching is implemented in `faculty.session.get_session`. But this calls `faculty.config.resolve_profile` which has a pre-defined order of places it pulls credentials from. It would be better if `faculty.session.get_session` takes in a `faculty.config.Profile` instance (or caching is implemented without having to always force resolving profiles). For example, on a platform server that has environmental variables defined, passing `credentials_path` to `faculty.session.get_session` has no effect.

Note that for my example there is a somewhat ugly workaround:

```
import faculty
import faculty.session
import faculty.clients

profile = faculty.config.load_profile('/path/to/config', 'default')
session = faculty.session.get_session(
domain=profile.domain, client_id=profile.client_id,
client_secret=profile.client_secret
)
client_class = faculty.clients.for_resource('cluster')
cluster = client_class(session)
```

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.