facebook / facebook/zstd

COVER_selectDict() uses stale customDictContentEnd after ZDICT_finalizeDictionary modifies dictContentSize

Ouverte
#4,750 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
C
Étoiles
27.9k
Forks
2.6k
Merge moyen
1 j 3 h
PR mergées (30 j)
8

Description

**Describe the bug**
In `lib/dictBuilder/cover.c`, `COVER_selectDict()` computes `customDictContentEnd` at line 1055 based on the initial `dictContentSize`,Then at line 1069, `ZDICT_finalizeDictionary()` is called and its **return value** overwrites `dictContentSize`,ZDICT_finalizeDictionary()` returns the actual dictionary size after adding the header, which can differ from the input `dictContentSize`. However, `customDictContentEnd` is **never updated** to reflect the new `dictContentSize`.

**To Reproduce**
The currently public API cannot easily trigger this bug, but the bug does exist in the code logic.

**Expected behavior**
Update `customDictContentEnd` after `ZDICT_finalizeDictionary()` modifies `dictContentSize`.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.