facebook / facebook/zstd

Dictionary ID can't >= 4294967177 in 32-bit build

Open
#4,580 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
27.9k
Forks
2.6k
Avg merge
1d 3h
Merged PRs (30d)
8

Description

4294967177 = (2**32-1) - 118

Here return `dictID`, if `dictID` is too large, it will be treated as an error code.
https://github.com/facebook/zstd/blob/bb1eedcf866e0abdd34b157d83e19d76eb82a6f7/lib/compress/zstd_compress.c#L5212

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.