facebook / facebook/zstd

More verbosity without welcome message

Abierto
#4,565 1 comentario 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
C
Estrellas
27.9k
Forks
2.6k
Merge medio
1 d 3 h
PR fusionados (30 d)
8

Descripción

When compressing from `stdin`, it would be nice with an option to see the progress without the `WELCOME_MESSAGE`.

Especially in scripts that invoke `zstd` many times.

Current behaviour:
```
ls -l |zstd -9 -v > ll.zst
*** Zstandard CLI (64-bit) v1.6.0, by Yann Collet ***
/*stdin*\ : 36.23% ( 1.17 KiB => 434 B, /*stdout*\)
```

Proposed:
```
ls -l |zstd -9 -v > ll.zst
/*stdin*\ : 36.23% ( 1.17 KiB => 434 B, /*stdout*\)
```

```
ls -l |zstd -9 > ll.zst
[shows nothing - both before and after change]
```

**Proposed simple solution:**
```diff
diff --git a/programs/zstdcli.c b/programs/zstdcli.c
index 01760ff8..86ea5a10 100644
--- a/programs/zstdcli.c
+++ b/programs/zstdcli.c
@@ -1335,7 +1335,7 @@ int main(int argCount, const char* argv[])
}

/* Welcome message (if verbose) */
- DISPLAYLEVEL(3, WELCOME_MESSAGE);
+ DISPLAYLEVEL(4, WELCOME_MESSAGE);

#ifdef ZSTD_MULTITHREAD
if ((operation==zom_decompress) && (setThreads_non1)) {
```
so that two or more `-v`'s are needed for the welcome message to be shown.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.