facebook / facebook/flow

[Enhancement Proposal] Detect pointless conditionals.

Abierto
#4,889 1 comentario 0 reacciones 0 asignados Ver en GitHub
enhancement feature request
Lenguaje dominante
Rust
Estrellas
22.3k
Forks
1.9k
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

This is a feature request that will likely require some discussion and bikeshedding.

Often in Javascript we will check if a value is undefined and do something based on that. Sometimes, however, a value is never defined and the code inside the conditional becomes unreachable. Flow is in a unique position to detect this and warn about it.

Here's a minimal example to explain what I mean:

```js
/* @flow */

// empty exact object type
type Data = {|
foo: string
|}

const data: Data = {
foo: "hello there"
}

// unreachable if statement
if (data.bar) {
console.log('Launch the rockets!')
}

// unreachable default value
console.log(data.bar || 'Default Value')
```

Here flow has the ability to unequivocally know that the value will not be defined, but the conditional implies that the programmer expected the value to be defined at some point.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.