Catch name_mapper exceptions
Offen
Crash
Effort: easy
- Vorherrschende Sprache
- Rust
- Sterne
- 22.3k
- Forks
- 1.9k
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
You can write name mappers like
module.name_mapper='foo\(bar\)?' -> '\1'
which will error since the matching group might not exist. This leads to an uncaught exception. This should be easy to fix - we should wrap the `Str.global_replace` calls in https://github.com/facebook/flow/blob/master/src/services/inference/module_js.ml with `try/with` blocks, emit an error, and soldier on.
Thanks @billschaller for the report!
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.