facebook / facebook/flow

Flow throws in package's source, but doesn't throw in installed version of package

Aperta
#3,656 5 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
22.3k
Fork
1.9k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I faced weird case w/ one of my libs.

Here is the repo: https://github.com/shakacode/react-validation-layer
I ship typedefs within a package (I copy source files w/ `.flow` suffix).
You can clone it and run flow to make sure that everything's fine (or just [look at the CI job](https://travis-ci.org/shakacode/react-validation-layer/jobs/218345634)).

However, when I add this package to the app and run flow, it throws:

screen shot 2017-04-04 at 14 59 55

Here is an empty repo to reproduce: https://github.com/alexfedoseev/flow-lib-typedefs-error
Just flow and lib are installed.

If I remove this suppress comment in the package source, it throws there. But if this comment exists in the installed version of the package, flow throws `Unused suppression`.

Flow versions are identical (`0.42.0`).

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.