facebook / facebook/flow

Using externally defined types for the arguments of generic classes causes strange ordering issues

Ouverte
#2,455 6 commentaires 0 réactions 1 personne assignée Réclamée par @avikchaudhuri Voir sur GitHub
bug Typing: unions/intersections
Langage dominant
Rust
Étoiles
22.3k
Forks
1.9k
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

The following minimal test case demonstrates some strange ordering issues:

``` es6
/* @flow */

import type {X} from './test-module';

type Y = {name: 'Y'};

class Clazz {
method(func: () => t1 | t2) { // fix by flipping the order of `t1` and `t2` here
func();
}
}

const r: Clazz = new Clazz(); // or by flipping the order of `X` and `Y` here
r.method((): X => ({name: 'X'}));
r.method((): Y => ({name: 'Y'}));
```

where `test-module.js` is defined as:

``` es6
/* @flow */

export type X = {name: 'X'};
export type Y = {name: 'Y'};
```

This bug only happens when at least one of the types is defined in an external module. If both `X` and `Y` are defined externally then it still happens, but you need to flip the order to see the problem again.

Although this sounds like a real edge case bug, I'm actually unable to use the knowledge I've gleaned to work around the issue in my real code because there are quite a number of types coming from a number of external modules, and it would be a non-trivial task to determine which order I should specify the types in to fix the problem.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.