facebook / facebook/flow

Support for Comparables with `valueOf`

Aberta
#2,406 1 comentário 4 reações 0 responsáveis Ver no GitHub
feature request
Linguagem predominante
Rust
Estrelas
22.3k
Forks
1.9k
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

Consider this:

``` javascript
interface Comparable {
valueOf(): number;
}

class Comparer {

greater (first: Key, second: Key): boolean {
// flow error: Cannot be compared to Comparable
return first > second;
}
}
```

The [`valueOf()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/valueOf) method gets special treatment in Javascript and returns the primitive value for an Object type.

It can be implemented by any object so that they can be used in comparisons with the '<', '==', '===' and '>' operators. However, from the example above it appears to be the case that flow doesn't understand that the `valueOf()` method in the `Comparable` interface can be used without calling `first.valueOf() > second.valueOf()` directly.

I'd love to see this implemented in flow. It will be nice if flow throws the error only if the given item is an object type and doesn't implement `valueOf()`.

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.