facebook / facebook/flow

Support for Comparables with `valueOf`

Open
#2,406 1 comment 4 reactions 0 assignees View on GitHub
feature request
Dominant language
Rust
Stars
22.3k
Forks
1.9k
PR merge metrics
No merged PRs in 30d

Description

Consider this:

``` javascript
interface Comparable {
valueOf(): number;
}

class Comparer {

greater (first: Key, second: Key): boolean {
// flow error: Cannot be compared to Comparable
return first > second;
}
}
```

The [`valueOf()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/valueOf) method gets special treatment in Javascript and returns the primitive value for an Object type.

It can be implemented by any object so that they can be used in comparisons with the '<', '==', '===' and '>' operators. However, from the example above it appears to be the case that flow doesn't understand that the `valueOf()` method in the `Comparable` interface can be used without calling `first.valueOf() > second.valueOf()` directly.

I'd love to see this implemented in flow. It will be nice if flow throws the error only if the given item is an object type and doesn't implement `valueOf()`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.