facebook / facebook/duckling

Rules with no Spaces in numerals

Abierto
#415 0 comentarios 0 reacciones 0 asignados Ver en GitHub
bug IT (Italian)
Lenguaje dominante
Haskell
Estrellas
4.3k
Forks
740
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Hi,

the rule below works for Italian in parsing number with three digits such as `tre cento venti` (320), but fails in recognizing the same expression without spaces (`trecentoventi`) which is actually the correct one in Italian.

Could anyone points out an easy way to transform this rule, to make it working without spaces?

Thanks! 🙏

https://github.com/facebook/duckling/blob/1b36e2b8191a1c37dc316e0ebf6c7468751faac6/Duckling/Numeral/IT/Rules.hs#L286

```haskell
ruleNumerals :: Rule
ruleNumerals = Rule
{ name = "numbers 200..999"
, pattern =
[ numberBetween 2 10
, numberWith TNumeral.value (== 100)
, numberBetween 0 100
]
, prod = \tokens -> case tokens of
(Token Numeral NumeralData{TNumeral.value = v1}:
Token Numeral NumeralData{TNumeral.value = v2}:
Token Numeral NumeralData{TNumeral.value = v3}:
_) -> double $ v1 * v2 + v3
_ -> Nothing
}
```

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.