facebook / facebook/docusaurus

Comments can end up displaying inside description meta

Abierto
#6,108 12 comentarios 1 reacción 0 asignados Ver en GitHub
bug domain: markdown
Lenguaje dominante
TypeScript
Estrellas
66.2k
Forks
10k
Merge medio
1 d 3 h
PR fusionados (30 d)
52

Descripción

### Have you read the Contributing Guidelines on issues?

- [X] I have read the Contributing Guidelines on issues.

### Prerequisites

- [X] I'm using the latest version of Docusaurus.
- [X] I have tried the `npm run clear` or `yarn clear` command.
- [X] I have tried `rm -rf node_modules yarn.lock package-lock.json` and re-installing packages.
- [ ] I have tried creating a repro with https://new.docusaurus.io.
- [X] I have read the console error message carefully (if applicable).

### Description

Issue: My .md or .mdx files are loading comments into the content of the meta property `og:description`
``````

### Steps to reproduce

Example code structure to replicate this issue:
```
---
slug: /link_here
title: Title text here
---

Page text here, lorem ipsum etc etc etc

## h2, etc etc etc
```

### Expected behavior

og:description should not be pulling comments in to fill its content

### Actual behavior

og:description seems to pull the first text after even if it's a comment?

No log messages output.

### Your environment

- Docusaurus version used: **2.0.0-beta.13, & 2.0.0-beta.9**
- Environment name and version (e.g. Chrome 89, Node.js 16.4): **Edge Version 96.0.1054.57 (Official build) (64-bit)**
- Operating system and version (e.g. Ubuntu 20.04.2 LTS): **Windows 10 Pro - 21H2**

I have already fixed this issue in prod on our site's affected page, https://docs.domination.finance/liquidity_providers, by manually overriding the meta tag for og:description

### Reproducible demo

_No response_

### Self-service

- [ ] I'd be willing to fix this bug myself.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.