facebook / facebook/docusaurus

Do not use React svg components for regularly used icons

Ouverte
#5,865 9 commentaires 3 réactions 0 personnes assignées Voir sur GitHub
domain: performance proposal
Langage dominant
TypeScript
Étoiles
66.2k
Forks
10k
Merge moyen
1 j 3 h
PR mergées (30 j)
52

Description

### Have you read the Contributing Guidelines on issues?

- [X] I have read the [Contributing Guidelines on issues](https://github.com/facebook/docusaurus/blob/main/CONTRIBUTING.md#reporting-new-issues).

### Motivation

This issue about updating the number of visible archived versions in the version dropdown lead to a weird build size diff on HTML files:

https://github.com/facebook/docusaurus/pull/5862#issuecomment-958881323

The diff in size is due to using an inlined SVG component for external links 😅 the SVG markup is duplicated in the HTML file for each item

![image](https://user-images.githubusercontent.com/749374/140104236-11e4344c-2f3c-49a6-a118-ff6f7ddb480c.png)

For reusable icons of our theme, we should rather require an `svg` file instead of using a React SVG component, to reduce HTML output size.

It can have a significant impact on pages with a lot of icons (due to navbar, footer, doc sidebar...)

### Self-service

- [ ] I'd be willing to do some initial work on this proposal myself.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.