facebook / facebook/docusaurus

Ideal image flashing when navigating back and forward

Abierto
#10,214 7 comentarios 0 reacciones 0 asignados Ver en GitHub
bug
Lenguaje dominante
TypeScript
Estrellas
66.2k
Forks
10k
Merge medio
1 d 3 h
PR fusionados (30 d)
52

Descripción

### Have you read the Contributing Guidelines on issues?

- [X] I have read the [Contributing Guidelines on issues](https://github.com/facebook/docusaurus/blob/main/CONTRIBUTING.md#issues).

### Prerequisites

- [X] I'm using the latest version of Docusaurus.
- [X] I have tried the `npm run clear` or `yarn clear` command.
- [X] I have tried `rm -rf node_modules yarn.lock package-lock.json` and re-installing packages.
- [X] I have tried creating a repro with https://new.docusaurus.io.
- [X] I have read the console error message carefully (if applicable).

### Description

Image flashing when navigating back and forward using Ideal Image

A possible fix would be to use browser native image lazy loading `` instead of [`react-ideal-image`](https://github.com/slorber/docusaurus-react-ideal-image) (also posted in https://docusaurus.io/feature-requests/p/use-browser-lazy-loading-in-plugin-ideal-image)

Swizzling code I'm currently using to avoid this problem

```ts
export default function IdealImage(props: Props): JSX.Element {
const { img, ...propsRest } = props

// In dev env just use regular img with original file
if (typeof img === 'string' || 'default' in img) {
return (
// eslint-disable-next-line jsx-a11y/alt-text

)
}

return (

)
}
```

### Reproducible demo

_No response_

### Steps to reproduce

1. Go to https://docusaurus.io/docs/playground
2. Navigate to another page
3. Navigate back

### Expected behavior

No flashing

### Actual behavior

Flashing

https://github.com/facebook/docusaurus/assets/68118705/8285459b-0711-4a6b-ba89-d24d64eccf04

![image](https://github.com/facebook/docusaurus/assets/68118705/bb45e9a2-d839-4362-91a9-4e93642c1440)

### Your environment

- Public source code:
- Public site URL: https://docusaurus.io/docs/playground
- Docusaurus version used:
- Environment name and version (e.g. Chrome 89, Node.js 16.4):
- Operating system and version (e.g. Ubuntu 20.04.2 LTS):

### Self-service

- [X] I'd be willing to fix this bug myself.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.