facebook / facebook/TestSlide

Cannot type check with `from __future__ import annotations`

未关闭
#329 0 条评论 0 个 reaction 已指派 1 人 已被 @williamlw999-fb 认领 在 GitHub 查看
主要语言
Python
星标
149
派生
62
PR 合并指标
30 天内没有已合并 PR

描述

`from __future__ import annotations` turns type annotations into strings that can later be evaluated at runtime via `typing.get_type_hints` see [PEP 563](https://peps.python.org/pep-0563/). This is problematic because TestSlide uses the following pattern to find the expected type:
```
try:
argspec = inspect.getfullargspec(template)
except TypeError:
return
expected_type = argspec.annotations.get("return")
```
In this scenario, expected_type is a `string` when the expected type is `Type` (see `_validate_argument_type()` which only works if expected_type is a `Type`).

It seems like a potential solution is:
```
try:
hints = get_type_hints(template)
expected_type = hints.get("return")
except TypeError:
return
```
Will continue testing (I am on python 3.8.6).

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。