facebook / facebook/TestSlide

Cannot type check with `from __future__ import annotations`

Open
#329 0 comments 0 reactions 1 assignee Claimed by @williamlw999-fb View on GitHub
Dominant language
Python
Stars
149
Forks
62
PR merge metrics
No merged PRs in 30d

Description

`from __future__ import annotations` turns type annotations into strings that can later be evaluated at runtime via `typing.get_type_hints` see [PEP 563](https://peps.python.org/pep-0563/). This is problematic because TestSlide uses the following pattern to find the expected type:
```
try:
argspec = inspect.getfullargspec(template)
except TypeError:
return
expected_type = argspec.annotations.get("return")
```
In this scenario, expected_type is a `string` when the expected type is `Type` (see `_validate_argument_type()` which only works if expected_type is a `Type`).

It seems like a potential solution is:
```
try:
hints = get_type_hints(template)
expected_type = hints.get("return")
except TypeError:
return
```
Will continue testing (I am on python 3.8.6).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.