facebook / facebook/TestSlide

Simplify typehints

Ouverte
#248 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
easy enhancement good first issue help wanted
Langage dominant
Python
Étoiles
149
Forks
62
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

As per @fornellas comments on #246 do these:
- Unions of BaseException & other exception types (eg: Exception). Shouldn't BaseException be enough? All Python exception are subclasses of it, I think it should work just fine with only it.

- There are lots of Callable types (no args, no return) or Callable[[a,b,c...], d], mostly related to DSL hooks, such as examples, before / after hooks etc. TBH, this PR is awesome as it is, but I was thinking about having custom types such as ExampleFunction = Callable[[_ContextData], None] (non-blocking here to be clear).

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.