f / f/react-wait

startWaiting with useEffect hook overrides waiters array

Aperta
#13 5 commenti 5 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
306
Fork
28
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Hi there!
Thank you for this awesome library.
I experienced a kind of weird behavior while working with this library.

**Description**
if I use method startWaiting in useEffect hook like

```
useEffect(() => {
startWaiting('first');
startWaiting('second');
}, []);
```
**Result**
waiters array contains only 'second' waiter, so waiters array is overwritten.

the same issue would be in the example below:

component1:

```
const Component1 = () => {

useEffect(() => {
const fetchData = async () => {
startWaiting('first');
const response = await apiCall();
endWaiting('first');
}
fetchData();
}, []);

return (/*react markup and Wait component inside*/);
```

component2:

```
const Component2 = () => {

useEffect(() => {
const fetchData = async () => {
startWaiting('second');
const response = await anotherApiCall();
endWaiting('second');
}
fetchData();
}, []);

return (/*react markup and Wait component inside*/);
```

component3:

```
const Component3 = () =>
(


);
```

in this case, every time I am trying to receive waiters array it will contain only 'second'.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.