expert-lsp / expert-lsp/expert

Go to definition to function defined by macro with name ending in `?` or `!` does not work

Ouverte
#853 9 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
bug
Langage dominant
Elixir
Étoiles
2.1k
Forks
113
Merge moyen
1 j 10 h
PR mergées (30 j)
26

Description

This is a tracking issue for a bug found by a coworker. #759 added support for going to definition to functions defined by a macro. But turns out is only works for functions with "regular" names (for example `MyApp.Repo.one/1`) but not for the ones ending in `?` or `!` (`MyApp.Repo.exists?/1`)

I opened PR to ElixirSense already, but I think current HEAD of it does not pass tests in Expert, so even after the merge we'd have to figure something out (fork and cherry-pick for a time being, perhaps?).

https://github.com/elixir-lsp/elixir_sense/pull/344

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.