exercism / exercism/typescript

Type errors in anagram tests when strict mode is enabled

Abierto
#1,594 2 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
TypeScript
Estrellas
165
Forks
173
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

https://github.com/exercism/typescript/blob/4026d9e897e1a0c93e6b42f3bd0cb72fc0d1eeaf/exercises/practice/anagram/anagram.test.ts#L11

In the provided Jest tests for the anagram exercise, several expected arrays are declared empty without an explicit type annotation.
When the TypeScript compiler is run with "strict": true (as it is in the default Exercism TypeScript tsconfig), noImplicitAny is also enabled by default. This causes TypeScript compilation errors for these untyped empty arrays.

Steps to Reproduce
1. Download the anagram exercise for the TypeScript track.
2. Install dependencies:
```bash
yarn install
```
3. Run test:
```bash
yarn test`
```

Actual Behavior:
Typescript reports errors like
```bash
anagram.test.ts:66:11 - error TS7034: Variable 'expected' implicitly has type 'any[]' in some locations where its type cannot be determined.
```

Expected Behavior
The tests should compile successfully under the default configuration without requiring learners to change type annotations locally.

Proposed Fix
Add explicit type annotations for all empty expected arrays. For example:
```diff
- const expected = []
+ const expected: string[] = []
```

Why this helps
- Keeps the tests type-safe while still compiling with "strict": true.
- Prevents learners from hitting compiler errors unrelated to the exercise logic.
- Makes the learning experience smoother without weakening the strictness settings.
- I would be happy to open a pull request with the fix if that would be helpful.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.