exercism / exercism/python

Tests appear to be running in alphabetical order for Raindrops

未关闭
#2,214 8 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
discussion 💬 maintainer action required❕ smolder🍲
主要语言
Python
星标
2.5k
派生
1.5k
PR 合并指标
30 天内没有已合并 PR

描述

I tried out a couple of exercises on the Python track today, and noticed with the Raindrops exercise in particular that the tests were requiring me to implement the entire algorithm on the second failure.

I'm working in Python 3.8.5.

I run the tests with the following command:

```
pytest -x raindrops_test.py
```

With the unchanged stub file in place, I get the following failure:

```
def test_2_to_the_power_3_does_not_make_a_raindrop_sound_as_3_is_the_exponent_not_the_base(
self
):
> self.assertEqual(convert(8), "8")
E AssertionError: None != '8'
```

This is a reasonable "first" failure, since it's a single number that should be turned into a string.
If I make that pass with a hard-coded `return "8"`, then this is the next failure I get:

```
def test_the_sound_for_105_is_pling_plang_plong_as_it_has_factors_3_5_and_7(self):
> self.assertEqual(convert(105), "PlingPlangPlong")
E AssertionError: '8' != 'PlingPlangPlong'
E - 8
E + PlingPlangPlong
```

Looking at the tests, the order that they are defined in is quite nice, in terms of pushing the implementation forward step by step.

I tried adding the following declaration after the `import unittest` statement, to see if this would cause the tests to be run in the order that they are defined:

```
unittest.TestLoader.sortTestMethodsUsing = None
```

This did not change the order that the tests are run in.

If I sort the tests alphabetically by name, it appears to correspond to the order that I'm seeing when doing the exercise:

While under normal circumstances I would want tests to be run in random order, in Exercism exercises I think that it would make more sense to run the tests in the order that they are defined.

Is there a declaration we can make in order to accomplish this?
If not, then I would propose that we rename tests by adding a numeric prefix to the test name (e.g.

```
def test_01_the_sound_for_1_is_1(self):
```

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。