exercism / exercism/problem-specifications

Use SitOnIt-CI to enforce minimum lifetime for Pull Requests

Aperta
#1,244 9 commenti 0 reazioni 0 assegnatari Vedi su GitHub
discussion
Lingua principale
Ruby
Stelle
358
Fork
563
Merge medio
18h 41m
PR unite (30g)
2

Descrizione

I've noticed it's common in this repository to wait for a while before merging a PR that has been rapidly reviewed in order to give other maintainers a chance to comment themselves. At this time, this is more of an unwritten courtesy; what about making it policy?

[SitOnIt-CI](https://github.com/apps/sitonit-ci) enforces just this, and is configurable per-repository.

I would suggest 24 hours as a required wait time; this is the default and requires no configuration.

As with any CI status service, any user with admin privileges on the repository may install the app or override it to merge anyway.

I would love to see some discussion about the pros/cons of enforcing wait times.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.