exercism / exercism/javascript-analyzer

Improve two-fer: recognise re-assignment

Ouverte
#52 5 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
TypeScript
Étoiles
16
Forks
21
Merge moyen
6 h 53 min
PR mergées (30 j)
2

Description

**Is your feature request related to a problem? Please describe.**

When a solution is provided with a re-assignment, the analyzer bails out of a lot of code paths.

```javascript
export function twoFer(name = 'you') {
const whomst = name
return `One for me, and one for ${whomst}.`
}
```

When a solution is provided with a re-assignment of the named argument, the analyzer doesn't recognise the shadowing:

```javascript
export function twoFer(name) {
name = name ? name : "you"
return `One for me, and one for ${name}.`
}
```

**Which exercise**
`two-fer`

**Describe the solution you'd like**

Simple re-assignments like the one above should be recognised and _disapproved_. They don't add any value to the solution.

Re-assignments of the named arguments should be recognised and _disapproved_. https://github.com/exercism/javascript-analyzer/issues/52#issuecomment-750298061

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.