exercism / exercism/java-analyzer

there is no need to use substring in the result method in this code, kindly review

Aperta
#176 1 commento 0 reazioni 1 assegnatario Rivendicata da @manumafe98 Vedi su GitHub
x:size/small
Lingua principale
Java
Stelle
13
Fork
27
Merge medio
4g 9h
PR unite (30g)
6

Descrizione

public class LogLevels {

public static String message(String logLine) {
int startMessageIndex = logLine.indexOf("]:") + 2;
String result = logLine.substring(startMessageIndex, logLine.length());
return result.trim();
}
public static String logLevel(String logLine) {
int startLevelIndex = logLine.indexOf("[") + 1;
int endLevelIndex = logLine.indexOf("]");
return logLine.substring(startLevelIndex, endLevelIndex).toLowerCase();
}
public static String reformat(String logLine) {
return LogLevels.message(logLine) + " (" + LogLevels.logLevel(logLine) + ")";
}
public static void result() {
String logLine = "[ERROR]: Invalid operation";
String formattedString = LogLevels.reformat(logLine);
}
}

and the suggestion is:
Consider using the [substring](https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#substring-int-int-) method in result to solve this exercise. but for this exercise the substring method is implemented in the other methods, kindly review.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.