exercism / exercism/elixir

log-parser improvements

未关闭
#1,162 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Elixir
星标
664
派生
416
PR 合并指标
30 天内没有已合并 PR

描述

There are some improvements to this exercise proposed in the initial PR that got postponed so we can see how the exercise is doing first and maybe collect more improvement ideas first.

## Exercise doesn't teach that different delimiters can be used for regular expressions

Maybe add a step that involves parsing several `/` and ask them to use another delimiter for readability. Can be checked via the analyzer because the delimiter is kept in the AST.

## Exercise doesn't teach about compiling regex with variable content

I wanted to add some step that would require an interpolated regex with escaping a variable, but I couldn't come up with anything thematic that wouldn't be better done with `String.starts_with?`.

How about adding a step to `tag_with_user_name/1?`
Maybe something like bolding the user names whenever they are mentioned without "User"?

```elixir
LogParser.tag_with_user_name("[INFO] User Alice created a new project.")
# => "[USER] Alice [INFO] User Alice created a new project"
LogParser.tag_with_user_name("[INFO] User Alice created a new project. Alice has a reputation of 643.")
# => "[USER] Alice [INFO] User Alice created a new project. **Alice** has a reputation of 643."
```

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。