exercism / exercism/elixir-analyzer

Is Enum.reduce the "best fitting Enum function" for total_quantity in `boutique-inventory`?

Aperta
#433 2 commenti 4 reazioni 0 assegnatari Vedi su GitHub
help wanted 🤝
Lingua principale
Elixir
Stelle
33
Fork
33
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Solution Implementation:

```elixir
def total_quantity(item) do
Map.values(item.quantity_by_size)
|> Enum.sum()
end

```

The solution says:
image

I agree that `reduce` is a good function/concept to practice with for this solution but "best fitting" seems like a stretch. It took me a long time to understand the concept of `reduce` when learning functional programming and this may be a head scratcher for some folks new to Elixir and functional programming togther.

Would it be possible to change that message to say "Use the Enum.reduce function in the total_quantity function to practice."?

This doesn't give folks who can't figure out `reduce` right away the feeling like they are doing it "wrong".

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.