evanw / evanw/node-source-map-support

Should globals be saved during installation?

Aperta
#199 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
2.2k
Fork
223
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I think source-map-support is most frequently used in testing and I just ran into an issue where I was using sinon to set up a mock HTTP server during a test. If that test threw an exception, sinon would try to use XMLHTTPRequest to fetch the file / source map against the mock HTTP server, receive a 404, and fail to translate the stack trace. I think it may make sense to save globals like XMLHTTPRequest during installation so that even if they are mocked, source-map-support can use the original.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.