evanw / evanw/node-source-map-support

Should globals be saved during installation?

Open
#199 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.2k
Forks
223
PR merge metrics
No merged PRs in 30d

Description

I think source-map-support is most frequently used in testing and I just ran into an issue where I was using sinon to set up a mock HTTP server during a test. If that test threw an exception, sinon would try to use XMLHTTPRequest to fetch the file / source map against the mock HTTP server, receive a 404, and fail to translate the stack trace. I think it may make sense to save globals like XMLHTTPRequest during installation so that even if they are mocked, source-map-support can use the original.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.