euroargodev / euroargodev/sensor_metadata_json

PREDEPLOYMENT_CALIB_DATE, SENSOR_FIRMWARE_VERSION and other names that aren't in the Argo users manual and perhaps should be

Aperta
#16 1 commento 1 reazione 2 assegnatari Rivendicata da @BrianKingNOC Vedi su GitHub
Lingua principale
Python
Stelle
5
Fork
3
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

There are a variety of metadata that aren't in the Argo users manual, or are in the Argo users manual with names that might no longer be 'optimal'.

The first is
SENSOR_FIRMWARE_VERSION
which is on the list to be agreed by ADMT

Another example is
PREDEPLOYMENT_CALIB_DATE
This ought to be controlled as a proper parseable field. At present, some DACs encode this inside
PREDEPLOYMENT_CALIB_COMMENT
but with no fixed format way of doing so.

Other examples would include
FLOAT_FIRMWARE_VERSION
At present we have just FIRMWARE_VERSION in the manual, but that name is now incomplete. It was OK before we wanted to keep sensor firmware versions as well. Our notion of what we want to store has evolved, and it would be useful to have more completely descriptive names going forwards. @Annie Wong pointed out that we should have
FLOAT_FIRMWARE_VERSION (presently FIRMWARE_VERSION)
FLOAT_MANUAL_VERSION (presently MANUAL_VERSION)
FLOAT_SERIAL_NO (already OK)

With the json meta files, we have the opportunity to overhaul the list of names that have become out of date.

We would hope that these would be adopted in the manual in due course, and before that there would need to be some translation when generating meta.nc for backwards compatibility.

If ADMT has appetite to change and update some of these names, then now would be a time to have a full review

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.