Update: Working on FeedLand API, making change in how users table works

Abierto
#32 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
15/100
Tipo de issue
Nueva funcionalidad
Claridad
Necesita aclaración
Estado de actividad
Estancado
Stack tecnológico
mysql
Área
api, database

Línea de trabajo

The issue names database.setUserPrefs but no source file or test. Start by locating that entry point and its callers, including feedlandHome and the markTwain prototype; done would require a maintainer-defined regression check that omitted preferences do not overwrite existing user values.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Hopefully there will be no breakage from this change, which I'm making very carefully.

First a bit of background.

  1. I'm working on a REST API for FeedLand, so we can build other UIs for the data in a feedland instance.
  2. I have a prototype app whose codename is markTwain. You will hear me refer to it from time to time.
  3. markTwain doesn't do everything feedlandHome does (that's the app that forms the UI for FeedLand as you use it now).
  4. So when you assign to the user's prefs, we don't have values for all the things we keep track of for users.
  5. As-written database.setUserPrefs will set the values of all columns, even if they weren't specified by the caller.
  6. This isn't a problem for feedlandHome because it always sends all the values.
  7. But it is a problem for markTwain. So I changed the functionality slightly so that if we don't have a value we don't change it to NULL which is what MySQL would substitute. (I investigate this thoroughly, hopefully.)

markTwain is a placeholder for "all future apps." I could have made MT supply all the values it doesn't do anything with, but this isn't very futuristic. I want to lay a good clean foundation here.

This change should not affect current FeedLand installations, but we should keep an eye out for problems.

I'll post a note in this thread when the changes are deployed.

Lenguaje dominante
HTML
Estrellas
11
Forks
4
Métricas de merge de PR
Sin PR fusionados en 30 d

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de scripting/feedlandInstall

Todos los issues de scripting/feedlandInstall

Issues similares

Más issues de Backend & API Design

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.