CSS Modules

Abierto
#958 2 comentarios 1 reacción 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Necesita aclaración
Estado de actividad
Estancado
Stack tecnológico
css, python, react
Área
frontend, web-dev

Línea de trabajo

Start by reading the vdom_to_etree and etree_to_vdom utilities mentioned in the issue, then review the linked React CSS Modules examples and previous issue #671. Compare the proposed parser, selector, scoping, caching, and stylesheet-serving options. Done means an agreed interface and implementation plan exists; the issue currently leaves those design choices unresolved.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

priority-3-low
Current Situation

Currently, there is no way to tie CSS to an individual component, such as React CSS Modules

Here's some samples on how this works in React

See previous issue #671

Proposed Actions

This should be possible by

  1. Parse a CSS file into selectors and style pairs such as {'#my-selector': { ... } }. We can do this via...
  2. Parsing the component's VDOM into an LXML node tree using our vdom_to_etree util function
  3. Determining where to apply styles via cssslect
  4. Convert the etree back into VDOM using etree_to_vdom.

Note: With the interfaces below, we might want to implement a cache_handler = ... parameter to allow for customization on how we store stylesheet in cache.

Inline Style Interface

The user interface may look something like this

@component
@css_module("/path/to/stylesheet.css") # Allow for string paths or a file handle
def my_component( ... ):
   return html.div({"className": "styles.my_selector"}, ... )

However, this kind of interface does not retain the same kind of dot notation that React CSS Modules support. If going with this implementation, we would be forced to apply all styling using in-line styles.

In-line styles are not necessarily an issue, but would severely increase size DOM in situations where one selector can apply to 100+ elements.

CSS Modules Imitation Interface

To more accurately imitate React, we might want to consider this interface instead.

styles = css_module("/path/to/stylesheet.css")  # Allow for string paths or a file handle

@component
@styles  # Makes the CSS module aware of how to uniquely scope class names (see `hash` below)
def my_component( ... ):
   return html.div({"className": styles.my_selector }, ... )

The appended stylesheet will have its selectors converted to be unique {filename}_{classname}_{hash}, and all values referenced by the dot notation (eg styles.my_selector) will use these unique selectors. The hash value should be based on the component's dotted path.

In this example, the uniquely generated selector may look something like styles_my_selector_309571057.

What to do with the stylesheet?

Generally, React CSS modules are precompiled (webpack-esque) and stored in some output directory, then it is left up the the webserver to serve them.

Since we currently have no way of pre-compiling CSS modules, we have a few options

  1. Serve the file's contents as a string within a html.style tag
    • This is the simplest solution, but would lead to duplicated style rules for each time the component is rendered on the page
  2. Force the user to display a component that renders all CSS modules in one stylesheet
    • Would require creating a load/unload framework for CSS Modules
  3. Force the user to display a component that renders one CSS module in a stylesheet
    • Gives the user more control over rending behavior
  4. Create a Python view that is effectively a primitive static file server
    • This could prove useful for future JavaScript module capabilities
  5. Compile CSS on-the-fly into an output directory and have the user serve this files themselves
    • Is less convenient than the methods above
    • Would not have compatibility with whitenoise
Lenguaje dominante
Python
Estrellas
8.1k
Forks
332
Métricas de merge de PR
Sin PR fusionados en 30 d

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de reactive-python/reactpy

Todos los issues de reactive-python/reactpy

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.