Graph API response field format mismatch with SDK object field format
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 45/100
Línea de trabajo
Reproduce el desajuste con JsonParseNode, ConditionalAccessPolicy y los valores de ejemplo de transferMethods, y compáralo después con la ruta de solicitud de GraphServiceClient. Rastrea cómo se analiza conditions.authenticationFlows.transfer_methods cuando la API devuelve una cadena separada por comas; se considera terminado cuando el SDK expone los métodos devueltos como la lista esperada de enums ConditionalAccessTransferMethods.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Describe the bug
The field in question is for Conditional Access Policies (https://graph.microsoft.com/v1.0/identity/conditionalAccess/policies): conditions.authenticationFlows.transferMethods. When specified in a policy, the graph API returns this field as a comma-separated string, e.g. "transferMethods": "deviceCodeFlow,authenticationTransfer". When parsed by this SDK in this format, ConditionalAccessPolicy.conditions.authentication_flows.transfer_methods get's incorrectly set to an empty array ([]).
The SDK expects the value of this field to be an array, rather than a comma-separated string. The following code demonstrates the incorrect and desired behaviors:
from kiota_serialization_json.json_parse_node import JsonParseNode
from msgraph_beta.generated.models.conditional_access_policy import ConditionalAccessPolicy
json_data = {
"displayName": "Test Device Code & Authentication Transfers",
"state": "enabled",
"conditions": {
...
"authenticationFlows": {
"transferMethods": "deviceCodeFlow,authenticationTransfer"
}
},
...
}
msgraph_sdk_obj = JsonParseNode(json_data).get_object_value(ConditionalAccessPolicy())
# msgraph_sdk_obj.conditions.authentication_flows.transfer_methods == []
fixed_json_data = {
...
"conditions": {
...
"authenticationFlows": {
"transferMethods": ["deviceCodeFlow", "authenticationTransfer"]
}
},
...
}
fixed_msgraph_sdk_obj = JsonParseNode(fixed_json_data).get_object_value(ConditionalAccessPolicy())
# fixed_msgraph_sdk_obj.conditions.authentication_flows.transfer_methods == [
# <ConditionalAccessTransferMethods.DeviceCodeFlow: 'deviceCodeFlow'>,
# <ConditionalAccessTransferMethods.AuthenticationTransfer: 'authenticationTransfer'>
# ]
The following screenshot shows that the API returns it in the comma-separated string format:
So the issue still exists when using the msgraph-sdk API request instead of the JSON parser. e.g.
from msgraph_beta.graph_service_client import GraphServiceClient
GraphServiceClient(...).identity.conditional_access.policies.by_conditional_access_policy_id('conditionalAccessPolicy-id').get()
And in the Entra UI it looks like the following:
I don't know whether this bug should be fixed in this SDK or in the Graph API itself.
Expected behavior
msgraph_sdk_cap_obj: ConditionalAccessPolicy
msgraph_sdk_cap_obj.conditions.authentication_flows.transfer_methods ==
[
<ConditionalAccessTransferMethods.DeviceCodeFlow: 'deviceCodeFlow'>,
<ConditionalAccessTransferMethods.AuthenticationTransfer: 'authenticationTransfer'>
]
# not []
How to reproduce
The code above can be used to reproduce.
SDK Version
1.31.0
Latest version known to work for scenario above?
No response
Known Workarounds
No response
Debug output
Click to expand for a full example JSON of a policy
{
"@odata.context": "https://graph.microsoft.com/v1.0/$metadata#identity/conditionalAccess/policies/$entity",
"@microsoft.graph.tips": "Use $select to choose only the properties your app needs, as this can lead to performance improvements. For example: GET identity/conditionalAccess/policies('<guid>')?$select=conditions,createdDateTime",
"templateId": null,
"displayName": "Test Device Code & Authentication Transfers",
"state": "enabledForReportingButNotEnforced",
"sessionControls": null,
"conditions": {
"userRiskLevels": [],
"signInRiskLevels": [],
"clientAppTypes": ["all"],
"servicePrincipalRiskLevels": [],
"insiderRiskLevels": null,
"platforms": null,
"locations": null,
"devices": null,
"clientApplications": null,
"applications": {
"includeApplications": ["None"],
"excludeApplications": [],
"includeUserActions": [],
"includeAuthenticationContextClassReferences": [],
"applicationFilter": null
},
"users": {
"includeUsers": ["All"],
"excludeUsers": [],
"includeGroups": [],
"excludeGroups": [],
"includeRoles": [],
"excludeRoles": [],
"includeGuestsOrExternalUsers": null,
"excludeGuestsOrExternalUsers": null
},
"authenticationFlows": {
"transferMethods": "deviceCodeFlow,authenticationTransfer"
}
},
"grantControls": {
"operator": "OR",
"builtInControls": ["block"],
"customAuthenticationFactors": [],
"termsOfUse": [],
"authenticationStrength@odata.context": "https://graph.microsoft.com/v1.0/$metadata#identity/conditionalAccess/policies('e7a127d6-b745-47da-814e-f909748cff0d')/grantControls/authenticationStrength/$entity",
"authenticationStrength": null
}
}
Configuration
macOS, python 3.12
Other information
No response
- Lenguaje dominante
- Python
- Estrellas
- 44
- Forks
- 16
- Merge medio
- 20 h 39 min
- PR fusionados (30 d)
- 3
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de microsoftgraph/msgraph-beta-sdk-python
-
enhancement
Dificultad 1/5 Menos de una hora Aptitud para principiantes 72/100
-
status:waiting-for-triage type:bug
Dificultad 3/5 1-2 días Aptitud para principiantes 55/100
-
type:bug type:investigation
Dificultad 3/5 1-2 días Aptitud para principiantes 48/100
microsoftgraph/msgraph-beta-sdk-python#1033 · 1 reacción ·
-
status:waiting-for-triage type:bug
Dificultad 3/5 1-2 días Aptitud para principiantes 42/100
microsoftgraph/msgraph-beta-sdk-python#1006 · 1 comentario ·
-
status:waiting-for-triage type:bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 48/100
microsoftgraph/msgraph-beta-sdk-python#987 · 2 comentarios ·
Todos los issues de microsoftgraph/msgraph-beta-sdk-python
Issues similares
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 86/100
zostera/django-bootstrap4#894 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
use-agent-os/agent-os#3276 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
zephyrproject-rtos/zephyr#119726 ·
-
area/auth bug comp/agent P3 platform/discord type/security
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
NousResearch/hermes-agent#117848 ·