Some of the semantic diagnostics use fileName and not relative file name as part of semantic diagnostics and it makes tsbuildinfo unportable

Abierto
#59,851 1 comentario 0 reacciones 1 asignado Ver en GitHub

@sheetalkamat ya está trabajando en esto.

Desde el 5/9/2024.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

🔎 Search Terms

semantic diagnostics file name, tsbuildinfo

🕗 Version & Regression Information
  • This changed between versions ______ and _______
  • This changed in commit or PR _______
  • This is the behavior in every version I tried, and I reviewed the FAQ for entries about _________
  • I was unable to test this on prior versions because _______
⏯ Playground Link

No response

💻 Code
// Your code here

Errors like File_0_is_not_a_module use file name directly and that means they will have full paths in buildInfo making it report incorrect path if tsbuildInfo is ported.
Also need to search through code base to see if there are more such cases and use relative file name instead:
In Checker:
error(errorNode, resolutionDiagnostic, moduleReference, resolvedModule.resolvedFileName)
error(errorNode, diag, moduleReference, resolvedModule!.resolvedFileName)
error(errorNode, Diagnostics.Output_file_0_has_not_been_built_from_source_file_1, redirect, resolvedModule.resolvedFileName);
chainDiagnosticMessages( errorInfo, Diagnostics.Could_not_find_a_declaration_file_for_module_0_1_implicitly_has_an_any_type, moduleReference, resolvedFileName, ),

🙁 Actual behavior

File '/b.ts' is not module.

🙂 Expected behavior

File 'relativeToFileReportedIn("/b.ts")' not module.

Additional information about the issue

No response

Lenguaje dominante
Go
Estrellas
111k
Forks
14.4k
Merge medio
1 d 19 h
PR fusionados (30 d)
117

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de microsoft/TypeScript

Todos los issues de microsoft/TypeScript

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.