Labeled methods should always be recorded, even if they match trivial-method filters

Abierto
#323 0 comentarios 1 reacción 2 asignados Ver en GitHub

@kgilpin ya está trabajando en esto.

Desde el 1/4/2026.

  • #324 de @copilot-swe-agent — abierto

Evaluación

Este issue todavía no se ha evaluado.

Descripción

Summary

Methods annotated with @Labels(...) from appmap-annotation are not recorded when the agent considers them "trivial" (e.g. simple getter/setter patterns like getFirstName() that just return a field). The agent's trivial-method filter takes precedence over the explicit label annotation.

Expected behavior

If a developer explicitly labels a method with @Labels(...), that method should always be recorded in the AppMap trace, regardless of whether it would otherwise be filtered out as trivial. The label annotation is a deliberate opt-in signal that the method is meaningful for analysis.

Observed behavior

Given a class like:

@Labels("secret")
public String getFirstName() {
    return this.firstName;
}

The method does not appear in the recorded AppMap events or classMap. In contrast, a method with identical logic but a non-getter name is recorded:

@Labels("secret")
public String firstName() {
    return this.firstName;
}

This was confirmed by comparing the recorded events across multiple test runs. Methods like getPet (which has a loop and conditional logic) are recorded normally — the filter appears to target methods based on complexity/pattern, not just the get prefix.

Workaround

Wrap the getter in a non-getter-named method and label that instead:

@Labels("secret")
public String firstName() {
    return this.firstName;
}

public String getFirstName() {
    return firstName();
}

This works but is awkward — it forces users to create redundant wrapper methods just to satisfy the agent's filter.

Environment

  • appmap-agent 1.30.0
  • appmap-annotation 1.28.0
  • Java 23 (OpenJDK)
  • Spring Boot 2.4.5
Lenguaje dominante
Java
Estrellas
88
Forks
17
Merge medio
2 d 2 h
PR fusionados (30 d)
1

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de getappmap/appmap-java

Todos los issues de getappmap/appmap-java

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.