[coverage] Conformance findings: DATATYPE-042

Abierto
#496 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
55/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Tranquilo
Stack tecnológico
sql, typescript

Línea de trabajo

Comienza con la prueba expected-failure DATATYPE-042 del coverage PR en tests/ y, después, compara el comportamiento previsto con el reference PR #644. Sigue cómo databricks-sql-nodejs informa de los metadatos de las dos consultas SELECT NULL. Se considera terminado cuando tanto los resultados con datos como los vacíos informan STRING para ambas columnas, conservan los nombres y los valores null, y cumplen las row-count assertions indicadas.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary

Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-nodejs. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-nodejs) is fixed, then flips green as a tripwire.

Findings

  • DATATYPE-042 [sea]: SEA/kernel reports NULL_TYPE (TTypeId 16) for an untyped SELECT NULL (VOID) result column instead of its STRING type, so it disagrees with a CAST(NULL AS STRING) sibling in the same result set; Thrift correctly reports STRING_TYPE
    • failing test: untyped NULL column is reported as STRING, matching its CAST(NULL AS STRING) sibling [sea] (see the coverage PR diff under tests/)
  • DATATYPE-042: SEA/kernel reports NULL_TYPE (TTypeId 16) for an untyped SELECT NULL (VOID) result column instead of its STRING type, so the column disagrees with a CAST(NULL AS STRING) sibling in the same result set; Thrift correctly reports STRING_TYPE

Reproduce & Expected

DATATYPE-042 — Verify that an UNTYPED NULL column -- a bare SELECT NULL expression, whose Databricks SQL type is VOID (spelled NULL on some surfaces) -- is reported by the driver as its STRING type, identically t…

Reproduce:

SELECT NULL AS untyped_null, CAST(NULL AS STRING) AS typed_null_string
SELECT NULL AS untyped_null, CAST(NULL AS STRING) AS typed_null_string FROM range(1) WHERE 1 = 0

Expected (per the shared spec):

  • completes without an exception
  • result has 2 column(s)
  • col 0 is named untyped_null
  • col 1 is named typed_null_string
  • result has exactly 1 row(s)
  • col untyped_null, row 0 is null
  • col typed_null_string, row 0 is null
  • completes without an exception
  • result has 2 column(s)
  • col 0 is named untyped_null
  • col 1 is named typed_null_string
  • result has exactly 0 row(s)
  • full assertion contract:
result:
- label: live_data
  no_exception: true
- label: live_data
  column_count: 2
- label: live_data
  column:
    index: 0
    name: untyped_null
- label: live_data
  column:
    index: 1
    name: typed_null_string
- label: live_data
  column_reported_type:
    name: untyped_null
    equals: STRING
- label: live_data
  column_reported_type:
    name: typed_null_string
    equals: STRING
- label: live_data
  column_reported_types_match:
    columns:
    - untyped_null
    - typed_null_string
- label: live_data
  row_count: 1
- label: live_data
  column:
    name: untyped_null
    is_null: true
- label: live_data
  column:
    name: typed_null_string
    is_null: true
- label: live_data
  column_data_agrees_with_reported_type:
    columns:
    - untyped_null
    - typed_null_string
- label: empty_result
  no_exception: true
- label: empty_result
  column_count: 2
- label: empty_result
  column:
    index: 0
    name: untyped_null
- label: empty_result
  column:
    index: 1
    name: typed_null_string
- label: empty_result
  column_reported_type:
    name: untyped_null
    equals: STRING
- label: empty_result
  column_reported_type:
    name: typed_null_string
    equals: STRING
- label: empty_result
  column_reported_types_match:
    columns:
    - untyped_null
    - typed_null_string
- label: empty_result
  row_count: 0

Context

Lenguaje dominante
TypeScript
Estrellas
36
Forks
50
Merge medio
1 d 6 h
PR fusionados (30 d)
12

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de databricks/databricks-sql-nodejs

Todos los issues de databricks/databricks-sql-nodejs

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.