Reconsider how the change type dialog handles newly entered types

Abierto
#4,965 2 comentarios 0 reacciones 1 asignado Ver en GitHub

@CouleeApps ya está trabajando en esto.

Desde el 4/4/2024.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

Component: UI Effort: Low Impact: High UI: Dialogs

Currently, when attempting to change a type for a variable or parameter, BN tests if the new type is correct as we type it, before clicking on the Accept button. However, this process can cause lags and make the 'Change Type' dialog unresponsive, especially if an incorrect type is entered.

You can reproduce this by

  1. Clicking on any variable or parameter and pressing Y
  2. Providing a random type, such as "asdasd123"
  3. Pressing Enter a few times (in order to make it more clear)
  4. See how the change type dialog becomes unresponsive

Here is an example GIF:

Recording

I encounter this issue in every RE session, and it often leads to wasted time. I suggest that BN performs type checking only when we press Enter or click on the 'Accept' button. This would eliminate the lag issue and allow for more appropriate error messages to be displayed regarding the error. In current implementation, we need to hover over the "Error parsing specified type" message to see details, which can be a bit difficult to notice.

Lenguaje dominante
C++
Estrellas
1.3k
Forks
298
Merge medio
5 d 5 h
PR fusionados (30 d)
19

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Vector35/binaryninja-api

Todos los issues de Vector35/binaryninja-api

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.