Allow accepting suggestion with the EndOfLine key (End) if cursor is at the end of line

Abierto
#3,705 3 comentarios 1 reacción 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
45/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
csharp, powershell
Área
cli

Línea de trabajo

Locate the PSReadLine key-handling paths for ForwardChar and EndOfLine, then review the provided ForwardCharAndAcceptNextSuggestionWord example. Compare their behavior when the cursor is at the end of the line. Done means End accepts the current suggestion in that condition while existing ForwardChar behavior remains unchanged.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Area-Predictors Issue-Enhancement
Prerequisites
  • Write a descriptive title.
Description of the new feature/enhancement

Currently, it is only possible to accept suggestions when at the end of line if the ForwardChar (right arrow) key is hit. I think it would also make sense to treat the EndOfLine (End) key the same way. I know that this is how zsh-autosuggestions work, I haven't tested if fish autosuggestions also work like that but I feel like it's an intuitive behavior since you're trying to go to the end of the suggested line. I'm sure it is possible with a script block (I haven't yet looked into how but probably will soon) but I think that this would be a sensible default to have.

Arguably, the End key makes more sense than the right arrow key, and the right arrow key could be used for accepting the next word but that's really just my opinion which doesn't really matter when there are already so many users that are used to this. + It is possible to change it with the provided ForwardCharAndAcceptNextSuggestionWord example.

Proposed technical implementation details (optional)

No response

[Edited by @daxian-dbw] Added one upvote to represent the duplicate issue https://github.com/PowerShell/PSReadLine/issues/3741

Lenguaje dominante
C#
Estrellas
4.4k
Forks
341
Sin PR fusionados en 30 d

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de PowerShell/PSReadLine

Todos los issues de PowerShell/PSReadLine

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.